Contibuting code changes to the EICrecon repository

Overview

Teaching: 10 min
Exercises: 10 min

Questions

• How do I submit code to the EICrecon repository?

Objectives

• Understand naming conventions for EICrecon

• Submitting a Pull Request for a contribution to EICrecon

Repository

We use GitHub as the main code repository tool. The repositories are located:

• EICrecon - EIC reconstruction algorithms and EIC-related code for JANA framework
• JANA2 - The core framework

If you hesitate where to file an issue or a question, then the most probably it should be done in EICrecon project. There are EICrecon issues and discussions

There is also EICrecon project board where one can see what issues are in work and what could be picked up.

Exercise:

• Go to EICrecon project board and see what tickets are marked as “TODO”

Contributing workflow

• A workflow starts from creating an issue with a bug report or a feature request. It is important to create an issue even if the subject was discussed on a meeting, personally, etc.

• Then create a branch out of the issue.

  

  

• After you commit and push changes to the branch, create a pull request (PR). As soon as PR is created a continious integration (CI) system will run to test the project compiles and runs on EIC environment. Any further push to this branch will trigger CI rerun the tests and check if merge is ready to be done. PRs are also a good place do discuss changes and code with collaborators. So it might be reasonable to create a PR even if not all work on issue is done. In this case create a Draft PR.

  

  

  To summarize:

  • Create PR
  • Fill the information
  • Use “Draft PR” if the work is not done
  • Assign a reviewer

• Before accepting the Pull Requiest code goes through a code review by one of the core developers. If you need someone particular to review your changes - select the reviewer from the menu. Otherwise one of the developers will review the code and accept the PR.

More on the EIC contribution guide is in this tutorial, video

Coding style

One can find coding style and other contributins policies at CONTRIBUTING.md. It is yet to be finished but one can find current decisions on coding style there

References

• EICrecon
• EICrecon-project
• EICrecon-issues
• EICrecon-discussions
• jana2
• EIC environment - youtube
• EIC environment - tutorial

EICrecon project on GitHub

Key Points

• Write code in a style consistent with the rest of the repository.

• Contributions should be made through the GitHub Pull Request mechansim.